fragile fix for: Singleton client API not yet initialized #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@storybook/client-api peer depends on react. @storybook/svelte@6.4.3 depends on @storybook/client-api and react@16.14.0. But your workspaces depend on @storybook/client-api and react@17.0.2. yarn why -R @storybook/client-api yarn why -R react Thats why Yarn has to create two copies of @storybook/client-api: the first copy which uses react@16.14.0 and the other copy which uses react@17.0.2
IanVS
approved these changes
Feb 22, 2022
|
Thanks @bfanger :) |
|
@bfanger What config did you try with Found your thread @ the Yarn repo & it helped me resolve a similar issue with |
The packageExtensions:
"@storybook/svelte@*":
peerDependencies:
react: "*"
react-dom: "*"
"@storybook/vue3@*":
peerDependencies:
react: "*"
react-dom: "*"This will force "dependencies": {
...
"react": "17.0.2",
"react-dom": "17.0.2"
}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To paraphase yarnpkg/berry#4122
@storybook/client-apipeer depends on react.@storybook/svelte@6.4.3depends on@storybook/client-apiandreact@16.14.0, but your workspaces depend on@storybook/client-apiandreact@17.0.2.Thats why Yarn has to create two copies of @storybook/client-api: the first copy which uses react@16.14.0 and the other copy which uses react@17.0.2
I've had little succes with the proposed
packageExtensionssolution, but after some mucking around withyarn why -Rcommand, I discovered that downgrading React to the same version and pinning the storybook version in example-react-ts to same version as the other packages (6.4.14) was enough to dedupe the@storybook/client-apipackage.Fixes #50 but its a fragile fix, when upgrading or adding dependencies the issue can resurface.